Skip to content

Add modules and TS defs for Volume, VolumeSlice, NRRDLoader #16745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 10, 2019
Merged

Add modules and TS defs for Volume, VolumeSlice, NRRDLoader #16745

merged 4 commits into from
Jun 10, 2019

Conversation

@looeee
Copy link
Collaborator

@looeee looeee commented Jun 9, 2019

Also moved Volume and VolumeSlice into the misc/ folder.

@looeee
Copy link
Collaborator Author

looeee commented Jun 9, 2019

Also added module for libs/gunzip.min.js. Just as with inflate.min.js, this is converted by hand since there is no equivalent ES6 module available.

Mugen87
Mugen87 reviewed Jun 9, 2019
View reviewed changes
Mugen87
Mugen87 reviewed Jun 9, 2019
View reviewed changes
@looeee
Copy link
Collaborator Author

looeee commented Jun 10, 2019

@Mugen87 this should be ready to merge 👍

@Mugen87 Mugen87 merged commit 7d10f3f into mrdoob:dev Jun 10, 2019
@Mugen87 Mugen87 added this to the r106 milestone Jun 10, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 10, 2019

Thanks!

@looeee looeee deleted the convert_nrrdloader_to_module branch June 30, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r106

Development

Successfully merging this pull request may close these issues.

3 participants

@looeee @mrdoob @Mugen87