Skip to content

Conversation

@looeee
Copy link
Collaborator

@looeee looeee commented Jun 9, 2019

GPUParticleSystem extends Object3D so I've moved it into the js/objects/ directory.

@Mugen87 Mugen87 added this to the r106 milestone Jun 9, 2019
@Mugen87 Mugen87 merged commit a792b5c into mrdoob:dev Jun 9, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 9, 2019

Thanks!

@xow
Copy link

xow commented Jun 18, 2019

Thanks heaps for including this!

I noticed it has a dependency on
https://github.com/mrdoob/three.js/blob/master/examples/textures/particle2.png
and https://github.com/mrdoob/three.js/blob/master/examples/textures/perlin-512.png not sure if that was intentional

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 19, 2019

This dependency is only optional since the respective texture parameters (particleNoiseTex and particleSpriteTex ) are optional, too. Nevertheless, I think it's cleaner to make these parameters mandatory and remove both hard coded URLs from the JS code. Do you want to make this change?

@looeee looeee deleted the convert_gpuparticlesystem_to_module branch June 30, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants