Skip to content

cleanup LDrawLoader #16714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2019
Merged

cleanup LDrawLoader #16714

merged 1 commit into from
Jun 7, 2019

Conversation

@gero3
Copy link
Contributor

@gero3 gero3 commented Jun 6, 2019 •
edited
Loading

This cleans LDrawLoader from some LGTM errors. I did not remove this LGTM error because it can be changed inside of the loop although the code could be less spaghetti code.

@mrdoob mrdoob added this to the r106 milestone Jun 7, 2019
@mrdoob mrdoob merged commit 289190c into mrdoob:dev Jun 7, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 7, 2019

Thanks!

@gero3 gero3 deleted the LDrawLoader branch September 11, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r106

Development

Successfully merging this pull request may close these issues.

2 participants

@gero3 @mrdoob