Skip to content

Add module and TS file for MarchingCubes.js #16703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 7, 2019
Merged

Add module and TS file for MarchingCubes.js #16703

merged 4 commits into from
Jun 7, 2019

Conversation

@looeee
Copy link
Collaborator

@looeee looeee commented Jun 6, 2019

I moved MarchingCubes.js from examples/ to examples/objects/. Not sure if that's the best places for it - since it extends the ImmediateRenderObject, perhaps it should go in examples/extras/objects/?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 6, 2019

MarchingCubes is also used in webvr_sculpt and webvr_vive_sculpt.

@looeee
Copy link
Collaborator Author

looeee commented Jun 6, 2019

Oops, fixed!

@Mugen87 Mugen87 merged commit 5438f45 into mrdoob:dev Jun 7, 2019
@Mugen87 Mugen87 added this to the r106 milestone Jun 7, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 7, 2019

Thanks!

@looeee looeee deleted the convert_marching_cubes_to_module branch June 30, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r106

Development

Successfully merging this pull request may close these issues.

3 participants

@looeee @Mugen87 @mrdoob