Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 4, 2019

Fixed #16669

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 4, 2019

@mrdoob
Copy link
Owner

mrdoob commented Jun 4, 2019

So the problem is that https://github.com/mrdoob/three.js/tree/dev/docs/examples doesn't have en and zh folders, right?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 5, 2019

Yes, that's right. Do you think it's better to re-organize the file structure of docs/examples instead of changing the JS code?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 13, 2019

Okay, I've introduced the same file structure (en/zh) similar to the api and manual directories. In this way, the doc pages are now ready for Chinese translation, too.

@Mugen87 Mugen87 merged commit 156e214 into mrdoob:dev Jun 14, 2019
@Mugen87 Mugen87 added this to the r106 milestone Jun 14, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 15, 2019

Awesome! Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some docs links broken?

2 participants