WebGLRenderTarget: add image.width/height to texture property #16651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
This was referenced Jun 11, 2019
jsantell
added a commit
to jsantell/three.js
that referenced
this pull request
Jun 17, 2019
…return an empty string if a data URL cannot be generated. Allows the serialization of a scene with a DataTexture/WebGLRenderTarget after mrdoob#16651 landed without throwing. Fixes mrdoob#16763.
jsantell
added a commit
to jsantell/three.js
that referenced
this pull request
Aug 23, 2019
…return an empty string if a data URL cannot be generated. Allows the serialization of a scene with a DataTexture/WebGLRenderTarget after mrdoob#16651 landed without throwing. Fixes mrdoob#16763.
jsantell
added a commit
to jsantell/three.js
that referenced
this pull request
Aug 23, 2019
…return an empty string if a data URL cannot be generated. Allows the serialization of a scene with a DataTexture/WebGLRenderTarget after mrdoob#16651 landed without throwing. Fixes mrdoob#16763.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the familiar warning
we now pass
renderTarget.textureinstead ofrenderTargetitself.Thing is, in passing the texture, we have no access to the texture dimensions, which are properties of the render target.
This PR uses the same approach as is used with
DataTextureto solve this problem.