Fix WebVR viewport size when presenting #16561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebVR stereo rendering is currently broken on dev because of same changes I introduced on this PR #16367 (sorry 😢)
Basically I was setting the viewport size correctly on https://github.com/mrdoob/three.js/blob/dev/src/renderers/webvr/WebVRManager.js#L72-L81
*please notice that I was using
renderWidthas one eye's width and no the whole render width for both eyes, that's why I multiplied by 2 when callingsetDrawingBufferSizehttps://github.com/mrdoob/three.js/blob/dev/src/renderers/webvr/WebVRManager.js#L78The problem is that if bounds were provided by the WebVR API,
updateViewportFromBoundsis being called and it's assuming thatrenderWidthis the whole render size and not just one eyehttps://github.com/mrdoob/three.js/blob/dev/src/renderers/webvr/WebVRManager.js#L185-L193
That's why currently everything is rendering in one eye, and half (1/4 actually) for each eye.