readRenderTargetPixels: add parameter to select active cube face from WebGLRenderTargetCube #16353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cube face from WebGLRenderTargetCube
mrdoob
changed the title
mrdoob
reviewed
May 1, 2019
Mugen87
reviewed
May 1, 2019
Mugen87
approved these changes
May 2, 2019
|
So, can i close this pull request now? |
Closing would mean the PR is not merged and your changes do not land in the library. @mrdoob will perform the merge after a final positive review. |
|
Thanks for stating that :) |
|
/bump |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue that you can't readRenderTargetPixels with a WebGLRenderTargetCube.
Fixes #16331