Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Apr 24, 2019

This PR ensures that TrackballControls is used with the renderer' canvas instead of document. Otherwise the following error occurs in Chrome when using the mouse wheel:

[Intervention] Unable to preventDefault inside passive event listener due to target being treated as passive.

https://threejs.org/examples/misc_controls_trackball

Certain examples using OrbitControls also need this fix. I wanted to make this PR not too big though. And because we might want to consider to make the second argument of TrackballControls's ctor mandatory.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Apr 24, 2019

@mrdoob mrdoob added this to the r105 milestone Apr 24, 2019
@mrdoob mrdoob merged commit a874829 into mrdoob:dev Apr 24, 2019
@mrdoob
Copy link
Owner

mrdoob commented Apr 24, 2019

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Apr 24, 2019

I'll cherry pick to gh-pages. I noticed these warnings today too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants