Skip to content

Docs: Corrected definition of Texture.premultiplyAlpha #16164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2019
Merged

Docs: Corrected definition of Texture.premultiplyAlpha #16164

merged 1 commit into from
Apr 6, 2019

Conversation

@WestLangley
Copy link
Collaborator

This is completely different from the current definition. I assume this PR is correct.

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 5, 2019

According to MDN the description of gl.UNPACK_PREMULTIPLY_ALPHA_WEBGL is:

Multiplies the alpha channel into the other color channels.

@mrdoob mrdoob added this to the r104 milestone Apr 6, 2019
@mrdoob mrdoob merged commit 0d43ae1 into mrdoob:dev Apr 6, 2019
@mrdoob
Copy link
Owner

mrdoob commented Apr 6, 2019

Thanks!

@WestLangley WestLangley deleted the dev-docs_texture branch April 6, 2019 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r104

Development

Successfully merging this pull request may close these issues.

3 participants

@WestLangley @Mugen87 @mrdoob