Skip to content

Conversation

@sciecode
Copy link
Contributor

LINE, ENAB, NNDS, REFL duplicates case clean up.

@looeee please confirm the correct cases were kept.

@sciecode
Copy link
Contributor Author

Incorrect rendering of webgl_loader_lwo. Implementing commit to fix changes.

@sciecode
Copy link
Contributor Author

Incorrect rendering not related with commit.
Introduced #16107, proposed re-fix #16113 (works).

@mrdoob mrdoob added this to the r104 milestone Mar 31, 2019
@mrdoob mrdoob merged commit 3c863b8 into mrdoob:dev Mar 31, 2019
@mrdoob
Copy link
Owner

mrdoob commented Mar 31, 2019

Thanks!

@sciecode sciecode deleted the dev2 branch March 31, 2019 18:45
@looeee
Copy link
Collaborator

looeee commented Apr 1, 2019

This is not correct, there's loads of LWOLoader: form already exists on parent errors.

@mrdoob please give me time to review PRs for the loader before merging.

@looeee
Copy link
Collaborator

looeee commented Apr 1, 2019

@sciecode when making changes to the Block and Chunk parsing section of the loader, you will need to check the changes against quite a few files. The simple test file in the example is not enough.

I have a big directory of LWO test files, but I'm not sure which ones I can share. I'll find that out and make a dropbox folder of test models.

@sciecode
Copy link
Contributor Author

sciecode commented Apr 1, 2019

@looeee I would greatly appreciate the test models.
I believe I've fixed the incorrect parsing types and removed correct duplicated cases on newly forked branch commit sciecode/three.js@623fab3.
If you could check the changes on modified LWOLoader.js and confirm it's ok, I would make a new PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants