Skip to content

add missing import #16057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2019
Merged

add missing import #16057

merged 1 commit into from
Mar 25, 2019

Conversation

@aardgoose
Copy link
Contributor

Missing import

flagged by eslint

eslint also flagged several variable redeclarations. Do you want these fixed?

@mrdoob mrdoob added this to the r103 milestone Mar 25, 2019
@mrdoob mrdoob merged commit 1433383 into mrdoob:dev Mar 25, 2019
@mrdoob
Copy link
Owner

mrdoob commented Mar 25, 2019

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Mar 25, 2019

eslint also flagged several variable redeclarations. Do you want these fixed?

Yes please 😇

@aardgoose aardgoose deleted the gltf-mod-fixes branch March 25, 2019 20:42
@donmccurdy
Copy link
Collaborator

donmccurdy commented Mar 25, 2019 •
edited
Loading

Thanks! We should look into why the modularize script is missing these, or they’ll get reverted in the future.

@aardgoose
Copy link
Contributor Author

OK, I wasn't sure if this was automated or not. But obviously it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r103

Development

Successfully merging this pull request may close these issues.

3 participants

@aardgoose @mrdoob @donmccurdy