Clarify documentation for Object3D copy method #16025
Conversation
|
@donmccurdy, I saw you were involved in some discussion about #14009, do you have an opinion about this? |
|
|
||
| Copy the given object into this object. | ||
|
|
||
| Note, the callbacks [page:.onAfterRender] and [page:.onBeforeRender] are not copied across. |
There was a problem hiding this comment.
To make this a little more general and cover EventDispatcher methods, let's say:
Note that event listeners and render callbacks ([page:.onAfterRender] and [page:.onBeforeRender]) are not copied.
There was a problem hiding this comment.
Would this be better?
Note: event listeners and user-defined callbacks ([page:.onAfterRender] and [page:.onBeforeRender]) are not copied.
There was a problem hiding this comment.
sorry for late response, thanks for feedback!
|
Suggested a wording addition, but otherwise I'm fine with this change thanks! |
|
Will fix post-merge. |
|
Thanks! |
|
It'd be really nice to know how frequently these callbacks are used for managing the stencil buffer. I imagine this is one of the main reasons why one might want access to the |
|
@pailhead do you mind creating a new issue? |
5 participants
Related to: #14009
After cloning an object, it took me a lot of effort to track down the reason that the clone was rendering differently. We use the on(After|Before)Render functions to set the stencil state and this wasn't clear to me until we used RenderDoc to see that the stencil state was different.
This should at least save some people some hassle.