Skip to content

Start WebVRManager animation when setting the animation callback #15991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

Start WebVRManager animation when setting the animation callback #15991

merged 1 commit into from
Mar 15, 2019

Conversation

@dmarcos
Copy link
Contributor

@dmarcos dmarcos commented Mar 15, 2019

VR render loop never kicks off If the event vrdisplaypresentchange fires before setAnimationLoop is invoked.

Add animation.start call in VRManager setAnimationLoop. Consistent with WebGLRenderer setAnimationLoop method

@mrdoob mrdoob added this to the r103 milestone Mar 15, 2019
@mrdoob mrdoob merged commit 3b2137d into mrdoob:dev Mar 15, 2019
@mrdoob
Copy link
Owner

mrdoob commented Mar 15, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r103

Development

Successfully merging this pull request may close these issues.

2 participants

@dmarcos @mrdoob