Skip to content

Conversation

@mrdoob
Copy link
Owner

@mrdoob mrdoob commented Mar 13, 2019

No description provided.

@mrdoob mrdoob added this to the r103 milestone Mar 13, 2019
@mrdoob mrdoob merged commit c72f961 into dev Mar 13, 2019
@mrdoob mrdoob deleted the editor branch March 13, 2019 18:07
@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 14, 2019

FYI: I note in the migration guide that npm run editor was removed.

https://github.com/mrdoob/three.js/wiki/Migration-Guide

@devingfx
Copy link
Contributor

Hello,

May I ask why you did remove electron launch ?

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 25, 2020

Because the editor is now a PWA.

@devingfx
Copy link
Contributor

Do you mean a "Progressive Web App" ?

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 25, 2020

Yep 😊 .

@devingfx
Copy link
Contributor

devingfx commented Sep 25, 2020

A PWA is to oppose to native mobile app... Not a already web app!
I don't understand why disabling the ability to launch this web app (that was already launchable in a browser) in electon makes it a PWA...

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 25, 2020

Things were added, too: #10944 (comment)

@mrdoob
Copy link
Owner Author

mrdoob commented Sep 25, 2020

@devingfx Electron uses more memory than a PWA. Every Electron app is a new Chromium instance. PWA reuses the browser instance it was installed with.

@devingfx
Copy link
Contributor

Thanks for answers guys! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants