Skip to content

Add a .editorconfig file to enforce coding style #15954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Add a .editorconfig file to enforce coding style #15954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61abd42
Add a .editorconfig file to enforce coding style
wmcmurray Mar 11, 2019
3286c15
Keep that top comment, like other big libs do
wmcmurray Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# http://editorconfig.org

root = true

[*]
end_of_line = lf
insert_final_newline = true

[*.{js,ts,html}]
charset = utf-8
indent_style = tab
indent_size = 2
Copy link
Collaborator

@gkjohnson gkjohnson Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is merged I don't think the config should enforce indent width considering it is only a visual configuration and doesn't affect the file written to disk. I often use 4 columns to indent, for example.

Copy link
Contributor Author

@wmcmurray wmcmurray Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, don't hesitate to tweak it to your needs, I just wanted to start the debate..
You guys know this codebase much more than I do ! 🙇‍♂️


[*.{js,ts}]
trim_trailing_whitespace = true