Skip to content

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented Mar 8, 2019

CTMLoader is the only loader inheriting Loader but it doesn't look it really needs to inherit. CTMLoader calls scope(this).createMaterial() but it can be replaced with THREE.Loader.prototype.createMaterial() without inheriting Loader as similarly LegacyJSONLoader does.

With this change, no loader will inherit Loader. We may remove Loader if we move initMaterials(), createMaterial() and Handlers to somewhere(LoaderUtils?).

Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's important to keep the loaders consistent so I think this change is a good one.

@mrdoob mrdoob added this to the r103 milestone Mar 8, 2019
@mrdoob mrdoob merged commit 2fcd7bd into mrdoob:dev Mar 8, 2019
@mrdoob
Copy link
Owner

mrdoob commented Mar 8, 2019

Thanks!

@takahirox takahirox deleted the CTMLoaderUpdate branch March 8, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants