Skip to content

Fix OutlineEffect #15812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2019
Merged

Fix OutlineEffect #15812

merged 3 commits into from
Feb 20, 2019

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented Feb 20, 2019

Fix OutlineEffect broken by #15571

@mrdoob mrdoob added this to the r102 milestone Feb 20, 2019
@mrdoob
Copy link
Owner

mrdoob commented Feb 20, 2019

How about just doing var renderTarget = null; here?

https://github.com/mrdoob/three.js/blob/dev/examples/js/effects/OutlineEffect.js#L407

@mrdoob
Copy link
Owner

mrdoob commented Feb 20, 2019

And var forceClear = false; while you're at it 😇

@takahirox
Copy link
Collaborator Author

takahirox commented Feb 20, 2019

That should be clearer. Updated, thanks.

@mrdoob mrdoob merged commit 21224cd into mrdoob:dev Feb 20, 2019
@mrdoob
Copy link
Owner

mrdoob commented Feb 20, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r102

Development

Successfully merging this pull request may close these issues.

3 participants

@takahirox @mrdoob @Mugen87