Allow Tube Geometry to be serialized and loaded #15789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Have you considered to implement |
Mugen87
reviewed
Feb 15, 2019
Collaborator
|
It seems you have removed the changes to |
Collaborator
|
Ups, seems I was too fast^^. In situations where you produce a lot of commits, it's a good idea to perform a "git reset", a new commit and then a force-push in order to keep the commit history more clean. |
Collaborator
|
The change is okay but it's important to highlight that serialization/deserialization is only possible with built-in curves (e.g. |
Mugen87
approved these changes
Feb 15, 2019
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes were also done in #15772.