Skip to content

Fix for OrbitControls not allowing keyboard input in iframe #15620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2019
Merged

Fix for OrbitControls not allowing keyboard input in iframe #15620

merged 2 commits into from
Jan 28, 2019

Conversation

@greggman
Copy link
Contributor

@greggman greggman commented Jan 21, 2019 •
edited by mrdoob
Loading

Fixes #15619

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 21, 2019

I think you somewhat implement the suggestion by @mrdoob right here: #9437 (comment)

TBH, I've changed my mind since this discussion. The behavior of OrbitControls with such a fix is better than before.

@mrdoob mrdoob added this to the r101 milestone Jan 28, 2019
@mrdoob mrdoob merged commit bc0c566 into mrdoob:dev Jan 28, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jan 28, 2019

Thanks!

@WestLangley
Copy link
Collaborator

WestLangley commented Feb 2, 2019

@greggman @Mugen87

This PR causes problems on MacOS Safari/Chrome. Not sure about other platforms...

One is now unable to toggle the Chrome Developer Tools or Safari Web Inspector with keystrokes when using OrbitControls. For example, opt-cmd-i.

@greggman greggman mentioned this pull request Feb 2, 2019
Merged
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 2, 2019

@WestLangley Yep, can reproduce. @greggman does already have a solution for this 👍

@WestLangley WestLangley mentioned this pull request May 22, 2019
Merged
@EliasHasle EliasHasle mentioned this pull request Aug 28, 2019
Closed
5 tasks
@marcofugaro marcofugaro mentioned this pull request Aug 27, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r101

Development

Successfully merging this pull request may close these issues.

4 participants

@greggman @Mugen87 @mrdoob @WestLangley