Audio: Add checks for detune on audio buffer for Safari #15588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
reviewed
Jan 15, 2019
src/audio/Audio.js
Outdated
| source.buffer = this.buffer; | ||
| source.detune.value = this.detune; | ||
|
|
||
| if ( source.detune ) { |
There was a problem hiding this comment.
What if it is zero? Test for undefined?
WestLangley
reviewed
Jan 15, 2019
src/audio/Audio.js
Outdated
|
|
||
| this.detune = value; | ||
|
|
||
| if ( !this.source.detune ) return; |
There was a problem hiding this comment.
if ( ! this.source.detune ) return;
There was a problem hiding this comment.
I would add a warning here:
console.warn( 'THREE.Audio: AudioBufferSourceNode.detune not supported by the browser.' );
Closed
Mugen87
changed the title
|
Updated. |
Mugen87
approved these changes
Jan 15, 2019
Mugen87
requested changes
Jan 21, 2019
|
|
||
| source.buffer = this.buffer; | ||
| source.detune.value = this.detune; | ||
| this.setDetune( this.detune ); |
There was a problem hiding this comment.
I think there is a problem if you set detune like this. Since isPlaying is still false at this line, the value is actually not assigned to the AudioBufferSourceNode.
There was a problem hiding this comment.
Definitely worth investigating, but I'll merge this for now so we no longer break in iOS 12.
|
Thanks! |
joshmarinacci
added a commit
to MozillaReality/mred
that referenced
this pull request
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15566