Skip to content

Skip non-POT texture fallback on WebGL2 #15574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

Skip non-POT texture fallback on WebGL2 #15574

merged 1 commit into from
Jan 31, 2019

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented Jan 14, 2019 •
edited by Mugen87
Loading

This PR skips non-POT texture parameter setting fallback on WebGL2.

Fixes #15554

@takahirox takahirox mentioned this pull request Jan 14, 2019
Closed
13 tasks
@Mugen87 Mugen87 added this to the r101 milestone Jan 29, 2019
@takahirox
Copy link
Collaborator Author

takahirox commented Jan 31, 2019

/ping

@mrdoob mrdoob merged commit 7fe9a41 into mrdoob:dev Jan 31, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jan 31, 2019

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jan 31, 2019

And thanks for the ping too, these PR sure get lost quickly... 😔

@takahirox
Copy link
Collaborator Author

takahirox commented Jan 31, 2019

No worry! There're so many issues and PRs. I know it's very hard to catch up everything. I often miss too hehe. And sending reminder is easy and doesn't hurt anything. Also I think we should help you more.

@Tibus
Copy link

Tibus commented May 30, 2019

Hi.
Could maybe add this feature in webgl2 supported features on the website as it’s a key feature of webgl2 and I tought it was not yet supported in threejs ? ;D

@Mugen87 Mugen87 mentioned this pull request May 31, 2019
Merged
@Mugen87
Copy link
Collaborator

Mugen87 commented May 31, 2019

@Tibus I hope #16627 makes this topic more clear.

@Tibus
Copy link

Tibus commented May 31, 2019

Perfect ;D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

WebGL2

Projects

None yet

Milestone

r101

Development

Successfully merging this pull request may close these issues.

[WebGL2] NPOT Texture should not fallback in webgl2

4 participants

@takahirox @mrdoob @Tibus @Mugen87