GLTFLoader: Reset spotlight default position. #15565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@donmccurdy I tried the updated GLTFLoader with gltf-test. three.js + Lights.gltf result:
Is the usage wrong? I have lights and IBL off. |
Collaborator
Author
|
@cx20 have you set renderer.physicallyCorrectLights=true? That will be required for matching the glTF spec. |
Contributor
|
@donmccurdy Thanks to your advice the problem of brightness has been resolved. three.js + physicallyCorrectLights flag + Lights.gltf result:
|
takahirox
approved these changes
Jan 25, 2019
Collaborator
takahirox
left a comment
takahirox
left a comment
There was a problem hiding this comment.
The comment makes sense. Looking good to me.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an inconsistency shown in KhronosGroup/glTF-Sample-Models#210.