Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 2, 2019

The easiest approach to ensure BufferGeometry is passed to the renderer.

@Mugen87 Mugen87 added this to the r101 milestone Jan 3, 2019
@Mugen87 Mugen87 merged commit 6eafe38 into mrdoob:dev Jan 3, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jan 3, 2019

Wouldn't it be better to show a error in the console instead so we can fix the code?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 3, 2019

The problem is that fixing the code would mean to change e.g. the usage of BoxGeometry to BoxBufferGeometry. In this context there is somewhat an inconsistency since a documentation page about BoxGeometry would directly create a BoxBufferGeometry. I thought we can clean this up if we change the geometry generators at some point like suggested here 😇: #15387 (comment)

@mrdoob
Copy link
Owner

mrdoob commented Jan 7, 2019

I see I see. Can we console.log it for now then? It's just so we don't forget about it.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 7, 2019

Okay, I'll make a PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants