Skip to content

Conversation

@ConradP
Copy link

@ConradP ConradP commented Dec 14, 2018

when parsing the MTL file, the ke value doesn't get converted into a array from string, resulting in errors in the rgb value. I think this was a miss from #15367

@jbaicoianu
Copy link
Contributor

Good catch, I didn't notice that the values were being translated there. Do you have any models which use the Ke value this way? All my test models use Ke_map rather than static values.

@ConradP
Copy link
Author

ConradP commented Dec 14, 2018

I noticed it when I was playing around with this free model I found on turbosquid.
https://www.turbosquid.com/Download/1041070_22559320
the color gets parsed out as { r : '0', g: '.', b:'0'} so it gave the plane a pinkish color.

@Mugen87 Mugen87 changed the title miss on em support for MTLLoader MTLLoader: Correctly parse emissive coefficient. Dec 14, 2018
@mrdoob mrdoob added this to the r100 milestone Dec 18, 2018
@mrdoob mrdoob merged commit cdfc353 into mrdoob:dev Dec 18, 2018
@mrdoob
Copy link
Owner

mrdoob commented Dec 18, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants