Skip to content

Conversation

@linbingquan
Copy link
Contributor

No description provided.

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 14, 2018

Can you please shortly explain what this bug fix is about?

@linbingquan
Copy link
Contributor Author

@Mugen87 I wanna to make shadow effect, when I toggle Checkbox of ReceiveShadow, but Editor doesn't render immediately.

image

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 17, 2018

Good catch! Indeed, the shadow casting works correctly on your branch.

@Mugen87 Mugen87 changed the title Editor: fixes bug Editor: Fixed shadow casting bug. Dec 17, 2018
@mrdoob
Copy link
Owner

mrdoob commented Dec 17, 2018

Hmm, I'm not able to reproduce the issue in https://threejs.org/editor/.
What are the steps to reproduce?

@mrdoob mrdoob added this to the r100 milestone Dec 17, 2018
@linbingquan
Copy link
Contributor Author

@mrdoob I make a DirectionalLight and a Box with Shadow cast, and Plane without Shadow receive. When I toggle Shadow receive of Plane, the shadow receiveing doesn't work immediately.

Result screen shot:
_20181218095252

and then I switch CheckBox tow times, the shadow receiveing works correctly.

Result screen shot:
_20181218095427

@mrdoob
Copy link
Owner

mrdoob commented Dec 18, 2018

Ah, I see. I can reproduce that and I understand why it's happening.
I think the fix is good.

@mrdoob mrdoob merged commit 5437258 into mrdoob:dev Dec 18, 2018
@mrdoob
Copy link
Owner

mrdoob commented Dec 18, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants