Fire and smoke example #15366
Merged
Fire and smoke example #15366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
requested changes
Dec 4, 2018
examples/webgl_fire.html
Outdated
| camera.add( pointLight ); | ||
| scene.add( camera ); | ||
|
|
||
| var plane = new THREE.PlaneGeometry( 20, 20 ); |
There was a problem hiding this comment.
Please use BufferGeometry at all places. So in this case PlaneBufferGeometry.
examples/webgl_fire.html
Outdated
| renderer.setPixelRatio( window.devicePixelRatio ); | ||
| renderer.setSize( window.innerWidth, window.innerHeight ); | ||
| renderer.autoClear = false; | ||
| renderer.antialias = true; |
There was a problem hiding this comment.
This line seems redundant to me.
examples/js/Fire.js
Outdated
| this.orthoCamera = new THREE.OrthographicCamera( textureWidth / - 2, textureWidth / 2, textureHeight / 2, textureHeight / - 2, 1, 2 ); | ||
| this.orthoCamera.position.z = 1; | ||
|
|
||
| this.fieldGeometry = new THREE.PlaneGeometry( textureWidth, textureHeight ); |
examples/js/Fire.js
Outdated
| this.field0.background = new THREE.Color( 0x000000 ); | ||
|
|
||
| this.field1 = new THREE.WebGLRenderTarget( textureWidth, | ||
| textureHeight, |
examples/js/Fire.js
Outdated
| var parameters = { | ||
| minFilter: THREE.NearestFilter, | ||
| magFilter: THREE.NearestFilter, | ||
| format: THREE.RGBAFormat, |
There was a problem hiding this comment.
The default is already THREE.RGBAFormat.
|
A better place for |
|
Review comments fixed. |
Mugen87
approved these changes
Dec 5, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution to three.js. I think this library is amazing and I want to give back.
This is an example of fire and smoke based on the research paper:
"Real-Time Fluid Dynamics for Games" by Jos Stam
http://www.dgp.toronto.edu/people/stam/reality/Research/pdf/GDC03.pdf