Catch promise rejections in GLTFParser.loadNode #15350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
reviewed
Nov 30, 2018
examples/js/loaders/GLTFLoader.js
Outdated
| var nodeDef = json.nodes[ nodeIndex ]; | ||
|
|
||
| return new Promise( function ( resolve ) { | ||
| return function( ) { |
Collaborator
There was a problem hiding this comment.
I think we'll need to reorganize this a little at some point — would be nice to flatten it and avoid the IIFE here, and also see #14875. But this looks like an improvement for now. 👍
Collaborator
There was a problem hiding this comment.
actually, for now could you just wrap the IIFE in parentheses, with no space between the ()?
( function() {
// ...
}() )I find that makes it easier to see we've returned a promise, not a function. Thanks!
donmccurdy
approved these changes
Nov 30, 2018
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current GLTFLoader behavior will silently fail with an uncaught promise rejection if an error (say, a bad buffer file load) happens while parsing a node. This change should propagate such errors up to the user's onError function.