MeshMatcapMaterial no longer requiring a matcap. #15313
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@WestLangley
I was able to use
DataTextureinsideMeshMatcapMaterial. I guess the problem was that the example was trying to setmatcap.imageandDataTextureuses that property differently.While looking at the issue, I realised that we could hide this complexity in the shader. If
matcapis not set now the shader writes white instead. The user will have to callmaterial.needsUpdateif they set amatcapafter it has been compiled already, but that's howmap,bumpMap, etc work too.