Skip to content

Conversation

@mrdoob
Copy link
Owner

@mrdoob mrdoob commented Nov 26, 2018

@WestLangley

I was able to use DataTexture inside MeshMatcapMaterial. I guess the problem was that the example was trying to set matcap.image and DataTexture uses that property differently.

While looking at the issue, I realised that we could hide this complexity in the shader. If matcap is not set now the shader writes white instead. The user will have to call material.needsUpdate if they set a matcap after it has been compiled already, but that's how map, bumpMap, etc work too.

@mrdoob mrdoob added this to the r99 milestone Nov 26, 2018
@mrdoob mrdoob merged commit 6b07f27 into dev Nov 26, 2018
@mrdoob mrdoob deleted the matcap branch November 26, 2018 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants