Skip to content

UnrealBloomPass: unnecessary variable redefinitions #15296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2018
Merged

UnrealBloomPass: unnecessary variable redefinitions #15296

merged 2 commits into from
Nov 25, 2018

Conversation

@vlucendo
Copy link
Contributor

@vlucendo vlucendo commented Nov 21, 2018

No description provided.

@mrdoob mrdoob added this to the r99 milestone Nov 22, 2018
@mrdoob
Copy link
Owner

mrdoob commented Nov 22, 2018

Hmm, unsure about the resx/resy change. Somehow changes the readability of the code.

As per rederTarget one... I think I would use var renderTargetHorizonal and var renderTargetVertical instead.

@vlucendo
Copy link
Contributor Author

vlucendo commented Nov 22, 2018

there you go :P

@mrdoob mrdoob merged commit 093c415 into mrdoob:dev Nov 25, 2018
@mrdoob
Copy link
Owner

mrdoob commented Nov 25, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r99

Development

Successfully merging this pull request may close these issues.

3 participants

@vlucendo @mrdoob @Mugen87