[TransformControls] Minor refactor and clean up. #15264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdinesh86
changed the title
|
What is the easiest way to live test this PR now that the rawgit is down? This should be OK, but I wanted to make sure there are no issues with touch. |
Actually, I noticed that. I was going to investigate. |
|
Yeah, this PR fixes the outliner not longer being able to move nodes around: https://raw.githack.com/sdinesh86/three.js/transformcontrols_v2_patch/editor/ |
|
lgtm |
|
Thanks! |
|
And this marks as my first ever PR in a project Thanks a lot ^^ :) |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix's issues such as,
Broken Drag and Drop functionality in the editor outliner panel.