OBJLoader: Fix material copy for lines and point clouds #15263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15175
It's not correct to use
LineBasicMaterial.copy()orPointsMaterial.copy()if the given material parameter is a phong material.Now,
OBJLoaderusesMaterial.copy()in order to copy common properties. The PR also fixes the wrong usage ofmaterialLinein context ofPointsMaterial. I assume this was a copy/paste error.I've tested with this
test.objfile:Just add an empty
MTLfile for testing.