WebGLRenderTarget: Set texture.generateMipmaps to false by default #15236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, light shadow maps have
generateMipmapsset totrue. This is becausetrueis the default value forWebGLRenderTarget.texture.generateMipmaps.Although somewhat subjective, I also think #7245 (comment) is reasonable. It says:
This PR affects
WebGLRenderTargetandWebGLRenderTargetCube.If this is merged, I will make a note of this change in the migration docs.
By the way, I do not like this pattern:
which alters the object passed in by the user. I think we should avoid using it.