Skip to content

Conversation

@WestLangley
Copy link
Collaborator

Currently, light shadow maps have generateMipmaps set to true. This is because true is the default value for WebGLRenderTarget.texture.generateMipmaps.

Although somewhat subjective, I also think #7245 (comment) is reasonable. It says:

Building mipmap pyramids out of generated textures should really only be done if you know what you're doing.

This PR affects WebGLRenderTarget and WebGLRenderTargetCube.

If this is merged, I will make a note of this change in the migration docs.


By the way, I do not like this pattern:

if ( options.minFilter === undefined ) options.minFilter = LinearFilter;

which alters the object passed in by the user. I think we should avoid using it.

@mrdoob
Copy link
Owner

mrdoob commented Nov 12, 2018

which alters the object passed in by the user. I think we should avoid using it.

Sounds good 👌

@mrdoob mrdoob added this to the r99 milestone Nov 12, 2018
@mrdoob mrdoob merged commit 226cbdc into mrdoob:dev Nov 12, 2018
@WestLangley
Copy link
Collaborator Author

@mrdoob Thanks for updating the migration docs. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants