Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 3, 2018

The current SSAO implementation is broken since a while now, see #8576

Unfortunately, I frequently see people trying to use a SSAO pass in their apps. I think it's better to comment out the example for now.

@mrdoob
Copy link
Owner

mrdoob commented Nov 5, 2018

Hmm, but if we hide it it'll never get fixed...

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 6, 2018

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 11, 2018

Okay, I have changed my mind^^. Let me first see if I can revise the shader implementation 😊. I've already managed to fix the depth-of-field and godrays demo, so maybe it will work here, too 😅

@Mugen87 Mugen87 closed this Nov 11, 2018
@mrdoob
Copy link
Owner

mrdoob commented Nov 12, 2018

That'd be great!
This may be a good reference:
http://john-chapman-graphics.blogspot.com/2013/01/ssao-tutorial.html

@mrdoob
Copy link
Owner

mrdoob commented Nov 12, 2018

@spite may have some pointers.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 13, 2018

New PR #15243 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants