Skip to content

Rename "e" parameter to "event" in event listeners #15199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2018
Merged

Rename "e" parameter to "event" in event listeners #15199

merged 1 commit into from
Nov 5, 2018

Conversation

@cywarr
Copy link
Contributor

@cywarr cywarr commented Nov 2, 2018

Having "e" instead of "event" caused error in Firefox. No errors in Chrome.

@cywarr
Rename "e" parameter to "event" in event listeners
0d618f3 
Having "e" instead of "event" caused error in Firefox. No errors in Chrome.
@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 2, 2018

See https://discourse.threejs.org/t/how-to-select-objects-with-a-selection-rectangle/4772 for context.

@mrdoob mrdoob added this to the r99 milestone Nov 5, 2018
@mrdoob mrdoob merged commit 84dedf2 into mrdoob:dev Nov 5, 2018
@mrdoob
Copy link
Owner

mrdoob commented Nov 5, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r99

Development

Successfully merging this pull request may close these issues.

3 participants

@cywarr @Mugen87 @mrdoob