Skip to content

OrbitControls: support panning with left mouse + shift key #15140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 29, 2018
Merged

OrbitControls: support panning with left mouse + shift key #15140

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d2c5df8
Made custom pan keys
Oct 26, 2018
b64d223
remove arrow function & added reuse method isPanEvent
Oct 26, 2018
00a8e03
callback was moved from some function
Oct 26, 2018
04a4880
revert && add shiftKey
Oct 29, 2018
fa5956a
fix description
leshkovichpvl Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion examples/js/controls/OrbitControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ THREE.OrbitControls = function ( object, domElement ) {
// The four arrow keys
this.keys = { LEFT: 37, UP: 38, RIGHT: 39, BOTTOM: 40 };

// The panning keys
this.panKeys = [ 'ctrlKey', 'metaKey' ];

// Mouse buttons
this.mouseButtons = { LEFT: THREE.MOUSE.LEFT, MIDDLE: THREE.MOUSE.MIDDLE, RIGHT: THREE.MOUSE.RIGHT };

Expand Down Expand Up @@ -679,7 +682,7 @@ THREE.OrbitControls = function ( object, domElement ) {

case scope.mouseButtons.LEFT:

if ( event.ctrlKey || event.metaKey ) {
if ( scope.panKeys.some( key => event[ key ] ) ) {

if ( scope.enablePan === false ) return;

Expand Down