support audio buffer node detune #15040
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
requested changes
Oct 12, 2018
docs/api/en/audio/Audio.html
Outdated
| [page:Audio.pause pause]() etc. methods. Default is *true*.</p> | ||
|
|
||
| <h3>[property:Number detune]</h3> | ||
| <p>Modify pitch. Default is *0*.</p> |
Collaborator
There was a problem hiding this comment.
I think I would add the metric which is cent.
Collaborator
|
@mrdoob Should we provide |
Owner
|
@Mugen87 I think so 👌 |
Collaborator
|
Okay, then let's add both methods to this PR. |
Owner
Contributor
Author
|
Updated. |
Mugen87
requested changes
Oct 16, 2018
|
|
||
| if ( this.isPlaying === true ) { | ||
|
|
||
| this.source.detune.setValueAtTime( this.detune, this.context.currentTime ); |
Collaborator
There was a problem hiding this comment.
Is there a special reason for using setValueAtTime()? We normally use setTargetAtTime(), see #11133 (comment)
this.source.detune.setTargetAtTime( this.detune, this.context.currentTime, 0.01 );
Collaborator
There was a problem hiding this comment.
Please also add both new methods to the documentation.
Contributor
Author
There was a problem hiding this comment.
I copied the playbackRate code, but I can change both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last audio buffer source node property to support, next to playbackRate.
https://developer.mozilla.org/en-US/docs/Web/API/AudioBufferSourceNode/detune