Skip to content

EXRLoader: make thrown exceptions more informative #14998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2018
Merged

EXRLoader: make thrown exceptions more informative #14998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions examples/js/loaders/EXRLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,12 @@ THREE.EXRLoader.prototype._parser = function ( buffer ) {
'RLE_COMPRESSION',
'ZIPS_COMPRESSION',
'ZIP_COMPRESSION',
'PIZ_COMPRESSION'
'PIZ_COMPRESSION',
'PXR24_COMPRESSION',
'B44_COMPRESSION',
'B44A_COMPRESSION',
'DWAA_COMPRESSION',
'DWAB_COMPRESSION'
];

var compression = parseUint8( dataView, offset );
Expand Down Expand Up @@ -1109,7 +1114,7 @@ THREE.EXRLoader.prototype._parser = function ( buffer ) {

} else {

throw 'Only supported pixel format is HALF';
throw 'EXRLoader._parser: unsupported pixelType ' + EXRHeader.channels[ channelID ].pixelType + '. Only pixelType is 1 (HALF) is supported.';

}

Expand Down Expand Up @@ -1151,7 +1156,7 @@ THREE.EXRLoader.prototype._parser = function ( buffer ) {

} else {

throw 'Only supported pixel format is HALF';
throw 'EXRLoader._parser: unsupported pixelType ' + EXRHeader.channels[ channelID ].pixelType + '. Only pixelType is 1 (HALF) is supported.';

}

Expand All @@ -1163,7 +1168,7 @@ THREE.EXRLoader.prototype._parser = function ( buffer ) {

} else {

throw 'Cannot decompress unsupported compression';
throw 'EXRLoader._parser: ' + EXRHeader.compression + ' is unsupported';

}

Expand Down