Skip to content

Conversation

@takahirox
Copy link
Collaborator

@mrdoob mrdoob added this to the r97 milestone Sep 3, 2018
@mrdoob mrdoob merged commit 6102fc0 into mrdoob:dev Sep 3, 2018
@mrdoob
Copy link
Owner

mrdoob commented Sep 3, 2018

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Sep 3, 2018

I think I would also remove most of the parameters and leave the constructor like this:

function Texture3D( data, width, height, depth )

@takahirox
Copy link
Collaborator Author

And we add .setXXX( value ) methods instead?

@mrdoob
Copy link
Owner

mrdoob commented Sep 3, 2018

Yes, and these can be set in Texture directly. But doesn't have to be done now, the user can always do...

var texture = new THREE.Texture3D( ... );
texture.anisotropy = 16;

I just want to avoid continuing the parameters mess in this new class.

@takahirox
Copy link
Collaborator Author

takahirox commented Sep 4, 2018

OK, so let's do function Texture3D( data, width, height, depth ) so far. And let's add setXXX() methods when we add setXXX() methods to regular Textures.

@mrdoob
Copy link
Owner

mrdoob commented Sep 4, 2018

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants