VRMLLoader: Fixed parsing bug when comments were present in the file. #14838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
reviewed
Sep 3, 2018
examples/js/loaders/VRMLLoader.js
Outdated
| var line = lines[ i ]; | ||
|
|
||
| // The # symbol indicates that all subsequent text, until the end of the line is a comment, | ||
| // and should be ignored. (see http://www.agocg.ac.uk/train/vrml2rep/part1/guide3.htm) |
Collaborator
There was a problem hiding this comment.
Is that link an authority?
I think the first line of your comment is adequate, unless comments are not in the official spec.
Collaborator
Author
There was a problem hiding this comment.
I've used another link that directly refers to ISO/IEC 14772. This one is definitely trustworthy.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14837.