Skip to content

remove unnecessary calculation in Vector3.project #14628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2018
Merged

remove unnecessary calculation in Vector3.project #14628

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9796f88
remove unnecessary calculation in Vector3.project
yaoyao-cn Aug 3, 2018
2c86988
improve performance of Vector3.(un)project, Matrix4.multiplyMatrices …
yaoyao-cn Aug 3, 2018
a6d174e
remote ()
yaoyao-cn Aug 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions src/math/Vector3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,27 +312,19 @@ Object.assign( Vector3.prototype, {

},

project: function () {
project: function ( camera ) {

var matrix = new Matrix4();

return function project( camera ) {
return this.applyMatrix4( camera.matrixWorldInverse ).applyMatrix4( camera.projectionMatrix );
Copy link
Collaborator

@Mugen87 Mugen87 Aug 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure using camera.matrixWorldInverse is safe? I wonder if there are scenarios where this matrix might not be up to date (or in sync with camera.matrixWorld)...

Copy link
Contributor Author

@yaoyao-cn yaoyao-cn Aug 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i am sure. camera.matrixWorldInverse was updated by the camera itself automatically in Camera.updateMatrixWorld. and it should be sync with camera.matrixWorld as the name implies.

Copy link
Owner

@mrdoob mrdoob Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! https://github.com/mrdoob/three.js/blob/dev/src/cameras/Camera.js#L60


matrix.multiplyMatrices( camera.projectionMatrix, matrix.getInverse( camera.matrixWorld ) );
return this.applyMatrix4( matrix );

};

}(),
},

unproject: function () {

var matrix = new Matrix4();

return function unproject( camera ) {

matrix.multiplyMatrices( camera.matrixWorld, matrix.getInverse( camera.projectionMatrix ) );
return this.applyMatrix4( matrix );
return this.applyMatrix4( matrix.getInverse( camera.projectionMatrix ) ).applyMatrix4( camera.matrixWorld );

};

Expand Down