rad / deg mismatch in fbx loader #14536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere not all Euler angles are provided in key frame
Collaborator
|
I think this should be fixed in #14523 since I've updated the way animation transforms are applied. |
Author
|
@looeee Yes, on your branch my animations are working as expected, thanks. I will wait for the merge and I'm closing my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having a problem with some of my models animations (sorry I cannot share them). What I found is that if there is no angle defined for one of the axie in an animation key frame then fbx loader uses a value from initial state but this value is in degrees while the values in animation keys ar already converted to radians.