Skip to content

Get normal from cachedData in GLTFExporter #14347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2018
Merged

Get normal from cachedData in GLTFExporter #14347

merged 1 commit into from
Jun 25, 2018

Conversation

@marcatec
Copy link
Contributor

@marcatec marcatec commented Jun 22, 2018

This fixes the glTF-Export, if you have the same Object multiple times in your scene.

takahirox
takahirox approved these changes Jun 22, 2018
View reviewed changes
Copy link
Collaborator

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@mrdoob mrdoob added this to the r94 milestone Jun 25, 2018
@mrdoob mrdoob merged commit d4d5cd5 into mrdoob:dev Jun 25, 2018
@mrdoob
Copy link
Owner

mrdoob commented Jun 25, 2018

Thanks!

@marcatec marcatec deleted the gltfexport-cached-normals branch July 20, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takahirox takahirox takahirox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r94

Development

Successfully merging this pull request may close these issues.

3 participants

@marcatec @mrdoob @takahirox