Skip to content

Loaders: Ensure consistent ctor of CompressedTextureLoaders. #14307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2018
Merged

Loaders: Ensure consistent ctor of CompressedTextureLoaders. #14307

merged 1 commit into from
Jun 16, 2018

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 16, 2018

This PR harmonizes the constructor of DDSLoader, KTXLoader and PVRLoader. It also ensures that DDSLoader and KTXLoader actually use LoadingManager (the manager property was undefined before).

@mrdoob mrdoob added this to the r94 milestone Jun 16, 2018
@mrdoob mrdoob merged commit 3c80386 into mrdoob:dev Jun 16, 2018
@mrdoob
Copy link
Owner

mrdoob commented Jun 16, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r94

Development

Successfully merging this pull request may close these issues.

2 participants

@Mugen87 @mrdoob