Skip to content

GLTFExporter: Fix multi material export #14286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2018
Merged

GLTFExporter: Fix multi material export #14286

merged 2 commits into from
Jun 14, 2018

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 14, 2018

If you export a mesh with a geometry of type Geometry and multiple materials, you are getting a runtime error since groups is undefined. This can be fixed by using the correct reference to the converted BufferGeometry in .processMesh().

@Mugen87 Mugen87 requested a review from takahirox June 14, 2018 10:13
takahirox
takahirox approved these changes Jun 14, 2018
View reviewed changes
Copy link
Collaborator

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@mrdoob mrdoob added this to the r94 milestone Jun 14, 2018
@mrdoob mrdoob merged commit c96f86c into mrdoob:dev Jun 14, 2018
@mrdoob
Copy link
Owner

mrdoob commented Jun 14, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takahirox takahirox takahirox approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r94

Development

Successfully merging this pull request may close these issues.

3 participants

@Mugen87 @mrdoob @takahirox