add params for cubemap params (to support mobile)

[richardmonette]

• Fixes a weird thing where the EquiangularToCubeGenerator had the format hard coded (it's now read from the source by default).

• Adds overrides for the type and format, specifically this makes it possible to tweak the webgl_materials_envmaps_exr example to work on mobile webGL (where only half precision texture is supported) Before the textures showed up as blank/black, see screenshot above for it now working nicely.

@WestLangley

[WestLangley]

Agreed.

I'm thinking that a more flexible API would be

EquiangularToCubeGenerator( sourceTexture, resolution, options );

where options is an object.

If you don't think that flexibility is necessary, then -- not to derail this thread -- I think we need to revisit the THREE.EXRLoader() output texture options. What should the output mips, encoding, and min/mag filters be for THREE.EXRLoader()?

[richardmonette]

What should the output mips, encoding, and min/mag filters be for THREE.EXRLoader()?

Good question. Perhaps we can take that into another discussion, and still 🚢this spot fix. I've updated to the options object, as suggested 👍

[WestLangley]

@richardmonette Thanks! The API change should be noted in the migration docs, especially if there is no console warning.

@mrdoob This looks good.

[richardmonette]

The API change should be noted in the migration docs

Happy to update this, can you please point me towards those docs? (Haven't ever had to update those yet! 😄)

[WestLangley]

https://github.com/mrdoob/three.js/wiki/Migration-Guide

[telime]

oh disagreement... I am looking forward to it.
"Renamed EquiangularToCubeGenerator to EquirectangularToCubeGenerator"

[mrdoob]

Ops! Any chance you can resolve the conflicts?

[mrdoob]

Thanks!

[WestLangley]

The API change should be noted in the migration docs, especially if there is no console warning.

Done.