-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Add BufferGeometry index optimization and memory functions #14116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrdoob
merged 21 commits into
mrdoob:dev
from
gkjohnson:optimize-buffer-geometry-indices
Jan 10, 2019
Merged
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
36aa5f4
Add optimization and memory functions
gkjohnson 3c46c2f
Merge remote-tracking branch 'mrdoob-origin/dev' into optimize-buffer…
gkjohnson b9951cc
Rename function to 'mergeVertices', create new BufferAttribute object…
gkjohnson 908fa73
Add some utility functions to BufferGeometryUtils
gkjohnson 523c340
Add missing clone and copy functions to InterleavedBufferAttribute
gkjohnson 7842eb7
Include InterleavedBufferAttribute cloning in a test
gkjohnson 99438ae
Merge pull request #2 from mrdoob/dev
gkjohnson 73dba53
Merge remote-tracking branch 'origin/dev' into optimize-buffer-geomet…
gkjohnson 814e782
Change precision to tolerance, update memory function name
gkjohnson 516cf70
Linting update
gkjohnson ee7c54a
Make mergeVertices work if an index array already exists
gkjohnson 64c4e2e
Merge remote-tracking branch 'mrdoob-origin/dev' into optimize-buffer…
gkjohnson 86f1c64
Support merging morphAttributes
gkjohnson c20dff3
Fix incorrect variable reference. "attribute" -> "oldAttribute"
gkjohnson d51c345
Merge branch 'dev' into optimize-buffer-geometry-indices
gkjohnson 7f521d4
Move `mergeVertices` to `BufferGeometryUtils`
gkjohnson b93c7c7
Remove the interleavedBufferAttribute and copy, clone functions
gkjohnson ae49679
Remove interleavedGeometryAttribute test
gkjohnson bd989c1
Use mergeVertices in physics volume example
gkjohnson ae9bc8c
add comments to example
gkjohnson 176163a
Fix tabs
gkjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: i think this got converted from tabs to spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Line 199 too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I'll get these when I get home today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Let me know if there's anything else!