Skip to content

MarchingCubes: Deprecated generateGeometry() #13985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2018
Merged

MarchingCubes: Deprecated generateGeometry() #13985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 2 additions & 42 deletions examples/js/MarchingCubes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,48 +690,8 @@ THREE.MarchingCubes = function ( resolution, material, enableUvs, enableColors )

this.generateGeometry = function () {

var start = 0, geo = new THREE.Geometry();
var normals = [];

var geo_callback = function( object ) {

for ( var i = 0; i < object.count; i ++ ) {

var vertex = new THREE.Vector3().fromArray( object.positionArray, i * 3 );
var normal = new THREE.Vector3().fromArray( object.normalArray, i * 3 );

geo.vertices.push( vertex );
normals.push( normal );

}

var nfaces = object.count / 3;

for ( i = 0; i < nfaces; i ++ ) {

var a = ( start + i ) * 3;
var b = a + 1;
var c = a + 2;

var na = normals[ a ];
var nb = normals[ b ];
var nc = normals[ c ];

var face = new THREE.Face3( a, b, c, [ na, nb, nc ] );
geo.faces.push( face );

}

start += nfaces;
object.count = 0;

};

this.render( geo_callback );

// console.log( "generated " + geo.faces.length + " triangles" );

return geo;
console.warn( 'THREE.MarchingCubes: generateGeometry() now returns THREE.BufferGeometry' );
return this.generateBufferGeometry();

};

Expand Down