Skip to content

ObjectLoader method chaining #13950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2018
Merged

ObjectLoader method chaining #13950

merged 2 commits into from
Apr 29, 2018

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented Apr 28, 2018

Let's have ObjectLoader setter methods chaining.

@donmccurdy
Copy link
Collaborator

donmccurdy commented Apr 28, 2018

As long as you're updating these docs, might as well use this rather than ClassName?

@takahirox
Copy link
Collaborator Author

takahirox commented Apr 28, 2018

Wanna consider it in another PR because of the consistency with other pages.

@mrdoob mrdoob added this to the r93 milestone Apr 29, 2018
@mrdoob mrdoob merged commit 8239719 into mrdoob:dev Apr 29, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r93

Development

Successfully merging this pull request may close these issues.

4 participants

@takahirox @donmccurdy @mrdoob @Mugen87