Skip to content

Fix WebGLRenderer copyTextureToTexture #13944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2018
Merged

Fix WebGLRenderer copyTextureToTexture #13944

merged 1 commit into from
Apr 28, 2018

Conversation

@takahirox
Copy link
Collaborator

@takahirox takahirox commented Apr 26, 2018

This PR fixes WebGLRenderer.copyTextureToTexture(). If pixels isn't ArrayBufferView, gl.texSubImage2D() doesn't take width and height arguments.

https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/texSubImage2D

@mrdoob mrdoob requested a review from Mugen87 April 27, 2018 05:26
@mrdoob mrdoob added this to the r93 milestone Apr 27, 2018
@mrdoob mrdoob merged commit 70c68fb into mrdoob:dev Apr 28, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 28, 2018

Thanks!

@takahirox takahirox mentioned this pull request May 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r93

Development

Successfully merging this pull request may close these issues.

3 participants

@takahirox @mrdoob @Mugen87